Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vertex AI] Renamed RPCError to BackendError #14027

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

andrewheard
Copy link
Contributor

Renamed the internal type RPCError to BackendError. Although it is internal, the name appears when printing the error. The name BackendError was chosen since the SDK is making JSON-REST over HTTP calls rather than RPCs (at least not directly) and it also differentiates from other HTTP errors not produced by the Vertex AI backend and network errors.

This move and rename is being done separately from functionality changes to make the diffs readable.

#no-changelog

@andrewheard andrewheard added this to the 11.5.0 - M156 milestone Nov 4, 2024
@andrewheard andrewheard marked this pull request as ready for review November 4, 2024 23:35
@andrewheard andrewheard merged commit fb856dc into main Nov 5, 2024
38 checks passed
@andrewheard andrewheard deleted the ah/vertex-backend-error branch November 5, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants